Skip to content

Conversation

@jramapuram
Copy link
Member

Fixes #28
Fixes #26

@9prady9 9prady9 added the Feature label Sep 2, 2015
@9prady9 9prady9 self-assigned this Sep 2, 2015
@9prady9
Copy link
Member

9prady9 commented Sep 2, 2015

This shall be merged after upstream PR has been merged and pulled in.

@jramapuram
Copy link
Member Author

@9prady9 : can you just test the index_gen() call before the merge?

@9prady9
Copy link
Member

9prady9 commented Sep 2, 2015

@jramapuram I actually tested the changes in upstream PR with this PR changes already.

row/col, index, index_gen - all these functions are working. I just haven't pushed the changes to this branch yet. I am waiting for upstream PR to merge so that i can update sub-module commit tag in rust wrapper.

@jramapuram
Copy link
Member Author

👍

@jramapuram
Copy link
Member Author

@9prady9 : Can this be merged now since the upstream changes are in? Are there any required modifications to the indexing here so that it conforms to your changes in arrayfire mainline? I have pushed in the generic type for the af_host function as well. One thing that remains here is the updating of the submodule. If you could test this and update that I think we will be good to go.

@9prady9
Copy link
Member

9prady9 commented Sep 13, 2015

@jramapuram Just one last commit from my side. I have it on my local branch on the office machine. Will push it on Monday for sure. I will also update the tag then to af3.1.

@jramapuram
Copy link
Member Author

Great, thanks!

@9prady9 9prady9 added this to the 3.2 milestone Sep 14, 2015
9prady9 added a commit that referenced this pull request Sep 14, 2015
@9prady9 9prady9 merged commit 7c2e386 into master Sep 14, 2015
@9prady9 9prady9 deleted the feature/index branch September 14, 2015 16:16
@jramapuram
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants